Fix NUMERIC columns being converted to integers (#624) #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some BigQuery configurations incorrectly return NUMERIC/BIGNUMERIC columns with INTEGER type in the schema, causing them to be parsed as integer64 and then converted to regular integers when bigint="integer". This fix ensures NUMERIC and BIGNUMERIC columns are always preserved as doubles regardless of schema inconsistencies, while still allowing true INTEGER columns to be converted according to the bigint parameter. - Add explicit handling for NUMERIC/BIGNUMERIC columns in parse_postprocess - Ensure bigint conversion only applies to true INTEGER columns - Add comprehensive test case to prevent regression 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Update actions/checkout from v3 to v4 across all workflows - Update actions/upload-artifact from v3 to v4 in test-coverage.yaml - Fixes deprecation warnings for CI/CD pipeline Addresses: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624
Some BigQuery configurations incorrectly return NUMERIC/BIGNUMERIC columns with INTEGER type in the schema, causing them to be parsed as integer64 and then converted to regular integers when bigint="integer".
This fix ensures NUMERIC and BIGNUMERIC columns are always preserved as doubles regardless of schema inconsistencies, while still allowing true INTEGER columns to be converted according to the bigint parameter.
🤖 Generated with Claude Code
This is created as an experiment, so please ignore if it is not fixing the problem or addresses the wrong issue.