Platform refactor: Decoupling spotify, Adding scaffolding for youtube #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
qzdl
commented
Oct 4, 2019
•
qzdl
commented
- Spotify removed from the core of the application
- notion of input / output platoform introduced
- enhancements to scraper:
- youtube video id retrieved from breakdown page
- platform extension enabled from Add support for youtube playlists #9
data API - README updated - gitignore updated - examples refreshed
- base 'Platform' class * inherited by spotify / youtube * platform specific code wrapped up in each platform implementation - notebooks added for youtube playlist inserts - README changed to a chad org file
- progress as far as: ` File "/home/samuel/git/spotify-samples/sample_finder.py", line 35, in samplify` * throwing on incorrect parameters. TODO: - extract originator_id from scraped data - normalise `source_playlist` DTO based on output platform - check the VinRican search - write some unit tests
- fixing runtime errors caused by incorrect platform references - soup parser updated to use 'html.parser' - logs now written to /logs
|
So it's looking much better all over the place; really wanting for some tests right now -- an awful, awful decision to go for classes |
qzdl
force-pushed
the
platform-refactor
branch
from
74276da to
a4c2db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.