Conversation
BadMagic100
reviewed
Mar 30, 2026
worlds/hk/options.py
Outdated
Comment on lines
+221
to
+222
| option_full = 2 | ||
| option_room = 3 |
There was a problem hiding this comment.
People will be confused about this distinction if they don't read carefully (nobody reads carefully). I would suggest maparea and fullarea to avoid the confusion (I will also be doing this internally on the client, not that it matters)
BadMagic100
reviewed
Mar 30, 2026
worlds/hk/options.py
Outdated
Comment on lines
+274
to
+275
| option_coupled = 1 | ||
| option_decoupled = 2 |
There was a problem hiding this comment.
is there a reason this is not 0/1? it's not a major issue but it's annoying that the default value deserialized when it's not provided (all bits 0 aka 0) is not the same as the default value of the option
Owner
Author
There was a problem hiding this comment.
nah, i got it like that and didn't touch it to not confuse the client bits that were already written,
can change it to whatever you prefer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds ER build off of #5
still seems to have resource state caching issues which were present in non-er flower quest but as expected seem exacerbated in er, but else should be complete
additionally adds option groups because i was annoyed finding the new options testing webhost