Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and update Cirun.io config to use labels #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aktech
Copy link

@aktech aktech commented Jul 28, 2022

See https://docs.cirun.io/reference/examples.html
Announcement here: https://twitter.com/AktechLabs/status/1551820040408006661

Now a single config can be used by multiple workflows using labels.

Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @aktech! Looks good to me. I've triggered the workflow runs just to double check that things are working.

@aktech
Copy link
Author

aktech commented Jul 28, 2022

Hey @hodgestar seems like your vCPU limit is 0 in that region.

@hodgestar
Copy link
Contributor

Hey @hodgestar seems like your vCPU limit is 0 in that region.

It worked in the past, so I don't know what happened. I will check a bit later. :/

@aktech
Copy link
Author

aktech commented Jul 28, 2022

Quota might have been reset I guess (due to non-usage probably):
https://github.com/qutip/qutip-cupy/pull/44/checks?check_run_id=7558192541

An error occurred (VcpuLimitExceeded) when calling the RunInstances operation: You have requested more
vCPU capacity than your current vCPU limit of 0 allows for the instance bucket that the specified instance type belongs to. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit."

@hodgestar
Copy link
Contributor

The account still has All G and VT Spot Instance Requests set to 64 so I'm still confused.

@hodgestar
Copy link
Contributor

Maybe removing instance_type: g4dn.xlarge from the config broke something?

@aktech
Copy link
Author

aktech commented Jul 31, 2022

The account still has All G and VT Spot Instance Requests set to 64 so I'm still confused.

That's for spot instance, since we have set preemptible: false, we're not using spot. I can set it to true in that case.

Maybe removing instance_type: g4dn.xlarge from the config broke something?

Where have we removed that? It's still there isn't it?

@aktech
Copy link
Author

aktech commented Jul 31, 2022

This time the AWS credentials didn't had permissions:

{
    "error": "An error occurred (AuthFailure.ServiceLinkedRoleCreationNotPermitted) when calling the RequestSpotInstances operation: The provided credentials do not have permission to create the service-linked role for EC2 Spot Instances."
}

Ref: https://github.com/qutip/qutip-cupy/pull/44/checks?check_run_id=7600656032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants