-
Notifications
You must be signed in to change notification settings - Fork 30
avoid string expr in to_next_multiple #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 6 files 6 suites 7m 28s ⏱️ Results for commit fec6ed3. ♻️ This comment has been updated with latest results. |
|
In the future, I think it would be better to avoid free-style branch names on the github repo. For non-issue branches there are already a wide variety of folder prefixes. |
shumpohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make my own version
|
At some point it probably makes more sense to change the expression backend |
the next limiting factor would probably be |
|
Ideally, we stir in a direction where the evaluations are not done at all, i.e. loop bodies are handled symbolically. |
|
that's probably a more long term goal right? At some point, most hardware will probably need evaluations |
…based on the quanta
Make variable names more verbose
This is up to a factor 5-6 faster than before in the branch with min_quanta