Skip to content

Conversation

@Nomos11
Copy link
Collaborator

@Nomos11 Nomos11 commented Aug 28, 2025

This is up to a factor 5-6 faster than before in the branch with min_quanta

@Nomos11 Nomos11 requested a review from shumpohl August 28, 2025 08:14
@github-actions
Copy link

github-actions bot commented Aug 28, 2025

Test Results

    6 files      6 suites   7m 28s ⏱️
1 234 tests 1 172 ✅  62 💤 0 ❌
7 404 runs  7 032 ✅ 372 💤 0 ❌

Results for commit fec6ed3.

♻️ This comment has been updated with latest results.

@shumpohl
Copy link
Member

In the future, I think it would be better to avoid free-style branch names on the github repo. For non-issue branches there are already a wide variety of folder prefixes. performance exists already

Copy link
Member

@shumpohl shumpohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make my own version

@shumpohl
Copy link
Member

At some point it probably makes more sense to change the expression backend

@Nomos11
Copy link
Collaborator Author

Nomos11 commented Aug 28, 2025

At some point it probably makes more sense to change the expression backend

the next limiting factor would probably be .subs for pulses with heavy MappingPT usage. Sympy itself recognizes this is slow as an open issue sympy/sympy#22240

@shumpohl
Copy link
Member

Ideally, we stir in a direction where the evaluations are not done at all, i.e. loop bodies are handled symbolically.

@Nomos11
Copy link
Collaborator Author

Nomos11 commented Aug 28, 2025

that's probably a more long term goal right? At some point, most hardware will probably need evaluations

@shumpohl shumpohl self-requested a review September 3, 2025 14:37
@shumpohl shumpohl merged commit 6d2ebc1 into master Sep 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants