Skip to content

Refactor trigger property logic to avoid self.trigger = self.trigger #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shumpohl wants to merge 1 commit into
base: main
Choose a base branch
from

Refactor trigger property logic to avoid `self.trigger = self.trigger`

3a15433
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Refactor trigger property logic to avoid self.trigger = self.trigger #168

Refactor trigger property logic to avoid `self.trigger = self.trigger`
3a15433
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results failed Dec 4, 2025 in 0s

1 fail, 24 pass in 12s

  4 files   4 suites   12s ⏱️
 25 tests 24 ✅ 0 💤 1 ❌
100 runs  98 ✅ 0 💤 2 ❌

Results for commit 3a15433.

Annotations

Check warning on line 0 in src.tests.mapping_test

See this annotation in the file changed.

@github-actions github-actions / Test Results

2 out of 4 runs failed: test_mapping_gui_map_automatically (src.tests.mapping_test) 

artifacts/pytest-results-3.11/test-results.xml [took 0s]
artifacts/pytest-results-3.12/test-results.xml [took 0s]
Raw output 
AssertionError: assert {'T1': {'test...06247294416>}} == {'T1': {'test...06247294416>}}
  Omitting 2 identical items, use -vv to show
  Differing items:
  {'T1': {'test_parameter': None}} != {'T1': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706248874976>}}
  {'T2': {'test_parameter': None}} != {'T2': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706247376336>}}
  Full diff:
    {
  -  'T1': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706248874976>},
  -  'T2': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706247376336>},
  +  'T1': {'test_parameter': None},
  +  'T2': {'test_parameter': None},
     'dac': {'voltage': <qcodes.parameters.parameter.Parameter: voltage at 140706248883616>},
     'dmm': {'current': <qumada.instrument.custom_drivers.Dummies.dummy_dmm.dmm_results_random: current at 140706247171904>,
             'voltage': <qumada.instrument.custom_drivers.Dummies.dummy_dmm.dmm_results_sinus: voltage at 140706247294416>},
    }
mocker = <pytest_mock.plugin.MockerFixture object at 0x7ff8b9c436b0>
qtbot = <pytestqt.qtbot.QtBot object at 0x7ff8b9c43560>
station_with_instruments = <qcodes.station.Station object at 0x7ff8ba08ed80>
script = <qumada.measurement.scripts.generic_measurement.Generic_1D_Sweep object at 0x7ff8b9c434d0>

    def test_mapping_gui_map_automatically(mocker, qtbot, station_with_instruments, script):
        # mock dialogs (specify behaviour in return_value and skip)
        mocker.patch("qumada.instrument.mapping.mapping_gui.MessageBox_notallmapped.exec", return_value=QMessageBox.No)
        mocker.patch("qumada.instrument.mapping.mapping_gui.MessageBox_duplicates.exec", return_value=QMessageBox.No)
        mocker.patch("qumada.instrument.mapping.mapping_gui.MessageBox_overwrite.exec", return_value=QMessageBox.No)
    
        w = MainWindow(
            station_with_instruments.components,
            script.gate_parameters,
        )
        w.show()
        qtbot.addWidget(w)
    
        # wanted mapping
        terminal_params = {
            "dmm": {"voltage": station_with_instruments.dmm.voltage, "current": station_with_instruments.dmm.current},
            "dac": {"voltage": station_with_instruments.dac.ch01.voltage},
            "T1": {"test_parameter": station_with_instruments.dci.A.temperature},
            "T2": {"test_parameter": station_with_instruments.dci.B.temperature},
        }
    
        # check if auto mapping yields wanted result
        # qtbot.mouseClick(w.button_map_auto, Qt.MouseButton.LeftButton)
        qtbot.keyPress(w, Qt.Key_A)
>       assert w.terminal_parameters == terminal_params
E       AssertionError: assert {'T1': {'test...06247294416>}} == {'T1': {'test...06247294416>}}
E         Omitting 2 identical items, use -vv to show
E         Differing items:
E         {'T1': {'test_parameter': None}} != {'T1': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706248874976>}}
E         {'T2': {'test_parameter': None}} != {'T2': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706247376336>}}
E         Full diff:
E           {
E         -  'T1': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706248874976>},
E         -  'T2': {'test_parameter': <qcodes.parameters.parameter.Parameter: temperature at 140706247376336>},
E         +  'T1': {'test_parameter': None},
E         +  'T2': {'test_parameter': None},
E            'dac': {'voltage': <qcodes.parameters.parameter.Parameter: voltage at 140706248883616>},
E            'dmm': {'current': <qumada.instrument.custom_drivers.Dummies.dummy_dmm.dmm_results_random: current at 140706247171904>,
E                    'voltage': <qumada.instrument.custom_drivers.Dummies.dummy_dmm.dmm_results_sinus: voltage at 140706247294416>},
E           }

src/tests/mapping_test.py:394: AssertionError
View more details on GitHub Actions