-
Notifications
You must be signed in to change notification settings - Fork 88
New Connector: MySql CDC Source #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
**{ | ||
"host": host, | ||
"port": port, | ||
"user": user, | ||
"password": password, | ||
"database": database, | ||
"table": table, | ||
"snapshot_host": snapshot_host or host, | ||
"state_dir": state_dir, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't need to be a dict
**{ | |
"host": host, | |
"port": port, | |
"user": user, | |
"password": password, | |
"database": database, | |
"table": table, | |
"snapshot_host": snapshot_host or host, | |
"state_dir": state_dir, | |
} | |
host=host, | |
port=port, | |
user=user, | |
password=password, | |
database=database, | |
table=table, | |
snapshot_host=snapshot_host or host, | |
state_dir=state_dir, |
"Initial snapshot is enabled and not yet completed - performing snapshot..." | ||
) | ||
|
||
if not self.is_snapshot_completed() or self.force_snapshot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bit of redundant logic here because is_snapshot_completed
also checks self.force_snapshot
. If you ask me, the method should not check force_snapshot
, it should only check actual completeness, not if the snapshot should be done forcefully.
Extracted from PR quixio/quix-samples#620 (made changes to be more in line with typical Source pattern).