Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncatchable error inside a promise (#810) #811

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laishere
Copy link
Contributor

Fix issue #810

quickjs.c Show resolved Hide resolved
quickjs.c Show resolved Hide resolved
quickjs.c Show resolved Hide resolved
@saghul
Copy link
Contributor

saghul commented Jan 10, 2025

It would be good to have a test for this.

@laishere
Copy link
Contributor Author

How to run all the tests? @saghul

I just ran

run-test262.exe tests.conf

Result: 0/29 errors, 3 excluded

Cannot run test262.conf.

BTW, I should add my test.js to tests directory right?

@saghul
Copy link
Contributor

saghul commented Jan 10, 2025

This wouldn't be a 262 test, so yeah adding it to the tests/ directory is the way.

@laishere
Copy link
Contributor Author

laishere commented Jan 10, 2025

I just realized that we need an interrupt handler to test it. So I can't do it in pure js. So would need a separate test or modify run-test262.c

@saghul
Copy link
Contributor

saghul commented Jan 10, 2025

Yes it would likely need to be its own C file with the simplified test.

@laishere
Copy link
Contributor Author

Should I add Makefile and CMakeLists.txt target for this test? @saghul

@saghul
Copy link
Contributor

saghul commented Jan 10, 2025

CMake should be the only requirement, since it shouldn't have EXCLUDE_FROM_ALL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants