Skip to content

Bump version to 0.1.1 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions DEV_NOTES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
# Dev notes

## Build and test

```
cargo clean
cargo build
cargo test
cd questdb-confstr-ffi/cpp_test
./compile
./run
```

## Linting

In addition, before pushing a PR, please run:
```
cargo fmt --all
cargo clippy --all-targets -- -D warnings
```

## Cutting a release

Let us assume we want to cut version `0.1.1` and the current version is `0.1.0`.

### 1. New branch
```shell
git switch -c v0.1.1
```

### 2. Update the version in both `Cargo.toml` files

```shell
$EDITOR questdb-confstr/Cargo.toml
$EDITOR questdb-confstr-ffi/Cargo.toml
```

### 3. Re-run all tests and lints

Don't forget about _clippy_: The newest version of Rust might have picked up
some new lints that we need to fix.

### 4. Commit the changes and create a PR
```shell
git add -u
git commit -m "Bump version to 0.1.1"
git push --set-upstream origin v0.1.1
```

N.B: _We don't need to update any `Cargo.lock` files for the ffi crate since
there are no dependencies._

### 5. Create a new PR, get it reviewed and merge it

https://github.com/questdb/questdb-confstr-rs/pull/new/

### 6. Publish both crates to crates.io

```shell
cargo login

(cd questdb-confstr && cargo publish --dry-run)
(cd questdb-confstr-ffi && cargo publish --dry-run)

(cd questdb-confstr && cargo publish)
(cd questdb-confstr && cargo publish)
```

(If in doubt, see the
"[Publishing on crates.io](https://doc.rust-lang.org/cargo/reference/publishing.html)" guide)

### 7. Write the release notes

* [Create a new release](https://github.com/questdb/questdb-confstr-rs/releases) on GitHub.
* Specify what changed in the release notes.
* Keep it readable (not autogenerated) and short.
23 changes: 3 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,7 @@
# QuestDB configuration string parser

This is for:
* The [questdb-confstr](./questdb-confstr) crate
Consists of:
* The [questdb-confstr](./questdb-confstr) crate (documents grammar)
* and its bindings for C [questdb-confstr-ffi](./questdb-confstr-ffi)

## Dev notes

To build and test:

```
cargo clean
cargo build
cargo test
cd questdb-confstr-ffi/cpp_test
./compile
./run
```

In addition, before pushing a PR, please run:
```
cargo fmt --all
cargo clippy --all-targets -- -D warnings
```
See the [developer notes](./DEV_NOTES.md) for more details on building, testing and cutting a release.
4 changes: 2 additions & 2 deletions questdb-confstr-ffi/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "questdb-confstr-ffi"
version = "0.1.0"
version = "0.1.1"
edition = "2021"
license = "Apache-2.0"
description = "C FFI bindings for questdb-confstr"
Expand All @@ -13,4 +13,4 @@ authors = ["Adam Cimarosti <[email protected]>"]
questdb-confstr = { path = "../questdb-confstr", version = "0.1.0" }

[lib]
crate-type = ["lib", "staticlib"]
crate-type = ["lib", "staticlib"]
2 changes: 1 addition & 1 deletion questdb-confstr-ffi/cpp_test/test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2024 QuestDB
* Copyright (c) 2019-2025 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion questdb-confstr-ffi/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2024 QuestDB
* Copyright (c) 2019-2025 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
2 changes: 1 addition & 1 deletion questdb-confstr/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "questdb-confstr"
version = "0.1.0"
version = "0.1.1"
edition = "2021"
license = "Apache-2.0"
description = "A parser for a configuration string format handling service names and parameters"
Expand Down
4 changes: 2 additions & 2 deletions questdb-confstr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2024 QuestDB
* Copyright (c) 2019-2025 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -101,7 +101,7 @@ impl<'a> PartialEq<&'a ErrorKind> for ErrorKind {
}
}

impl<'a> PartialEq<ErrorKind> for &'a ErrorKind {
impl PartialEq<ErrorKind> for &ErrorKind {
fn eq(&self, other: &ErrorKind) -> bool {
*self == other
}
Expand Down
2 changes: 1 addition & 1 deletion questdb-confstr/tests/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* \__\_\\__,_|\___||___/\__|____/|____/
*
* Copyright (c) 2014-2019 Appsicle
* Copyright (c) 2019-2024 QuestDB
* Copyright (c) 2019-2025 QuestDB
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down
Loading