fix: change min duration from 5 to 1 (#37)

* fix: added 1 to duration option * test: update test Co-authored-by: Benedicte Raae <[email protected]>
queen-raae · Dec 24, 2021 · 46b8d62 · 46b8d62
1 parent c82854b
commit 46b8d62
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/plugin/gatsby-node.js b/plugin/gatsby-node.js
@@ -11,7 +11,7 @@ exports.pluginOptionsSchema = ({ Joi }) => {
       .default("regular"),
     duration: Joi.number()
       .integer()
-      .min(5)
+      .min(1)
       .default(15)
       .description("Duration of snowfall in seconds"),
     season: Joi.object()

diff --git a/plugin/gatsby-node.test.js b/plugin/gatsby-node.test.js
@@ -118,7 +118,7 @@ describe("pluginOptionsSchema", () => {
   });
 
   describe("duration", () => {
-    it("valid for int over 4", async () => {
+    it("valid for int over 0", async () => {
       const options = {
         duration: 10,
       };
@@ -130,7 +130,7 @@ describe("pluginOptionsSchema", () => {
       expect(isValid).toBe(true);
     });
 
-    it("valid for int string over 4", async () => {
+    it("valid for int string over 0", async () => {
       const options = {
         duration: "16",
       };
@@ -142,17 +142,17 @@ describe("pluginOptionsSchema", () => {
       expect(isValid).toBe(true);
     });
 
-    it("invalid for int under 5", async () => {
+    it("invalid for int under 1", async () => {
       const options = {
-        duration: 3,
+        duration: 0,
       };
       const { isValid, errors } = await testPluginOptionsSchema(
         pluginOptionsSchema,
         options
       );
 
       expect(isValid).toBe(false);
-      expect(errors).toEqual([`"duration" must be greater than or equal to 5`]);
+      expect(errors).toEqual([`"duration" must be greater than or equal to 1`]);
     });
 
     it("invalid for float", async () => {
@@ -165,10 +165,7 @@ describe("pluginOptionsSchema", () => {
       );
 
       expect(isValid).toBe(false);
-      expect(errors).toEqual([
-        `"duration" must be an integer`,
-        `"duration" must be greater than or equal to 5`,
-      ]);
+      expect(errors).toEqual([`"duration" must be an integer`]);
     });
 
     it("invalid for non int string", async () => {