fix: clear sensitive state on lock and flag IDN origins#171
Open
alez04 wants to merge 4 commits into
Open
Conversation
8b466df to
62e88de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revealedSeed,passphraseInput, andclose the reveal-seed and passphrase-prompt drawers in
manage-accounts.tsx.dapp-approval-drawer.tsxalready tracked lock state; it now also clearspassphrasein the same effect.hasIdnHostnameutility that detectsxn--punycode or non-ASCIIcharacters in a parsed hostname. A shared
IdnWarningBadgecomponent rendersan amber pill below the origin in the dApp approval drawer and the
connected-sites settings page.
Test plan
closes and seed is cleared before the
/unlockredirectpassphrase field clears and drawer closes
/unlockflow still works normallyxn--origin — amber"Internationalized domain" badge appears below the origin