WIP Support multi-value logType filter in GetEvents and rename eventType …#122
Open
WIP Support multi-value logType filter in GetEvents and rename eventType …#122
Conversation
…to logType - Allow comma-separated logType values in GetEvents filter (e.g. "0,1,3") - Use ES `terms` query for multiple values, `term` for single value - Rename filter key from eventType to logType across validation, query builder, tests and proto docs - Simplify createEventsQuery by removing unnecessary bytes.Buffer
Member
|
Is there a related issue? |
Contributor
Author
|
Yes. I created it last week #117 |
Member
|
The filter logic has been heavily refactored in the dev branch so this PR should not get merged. We can add this next sprint or I can maybe include it in the current dev branch. |
qubicmio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to logType
termsquery for multiple values,termfor single value