Generate "unique template" by default #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbonegi
approved these changes
Jul 18, 2018
|
Can this be rebased on the current master please? |
|
Done |
|
@jouvin so actually, it was not working but because of a change in the version of the panc compiler (an error message that changed). With the new master it should work. Could you please rebase ? I will post that same message in other pull requests sharing the same issue. |
jouvin
force-pushed
the
unique_template
branch
from
9bc60dd to
d937130
Compare
Contributes to quattor#92 Change-Id: I152bab1c470594c47553f315bbc842e0e36e998d
|
@xaf Done! |
|
Merged in 90b6109 |
joaocosta
added a commit
to joaocosta/aquilon
that referenced
this pull request
Jan 13, 2025
…_merge/master/by_topic/AQUILON_7558_add_sandbox to master * commit '216b195be7eb74f0d9d7a34e071d0ab7ef23bea1': Fix sandbox preparation functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default template type from nothing to
unique. It doesn't add the possibility to generate "non unique" templates as it seems unlikely that the broker may have to generate such a template (as an example, the template library contains very few such templates) and it would be easy to add another specific class for this (as for structure templates) if need be.Contributes to #92
Change-Id: I152bab1c470594c47553f315bbc842e0e36e998d