fix(book): add missing support for configurable link target and rel attributes in the book project configuration

[mcanouil]

The update adds support for the repo-link-target and repo-link-rel attributes in the book project configuration.

The logic is similar to what was done for website/repo-actions:

• quarto-cli/src/project/types/website/website-navigation.ts

  Lines 753 to 785 in 9311ca8

  	const linkTarget = websiteConfigString(kSiteRepoLinkTarget, config);
  	const linkRel = websiteConfigString(kSiteRepoLinkRel, config);
  	// get the action links
  	const links = repoInfo
  	? repoActionLinks(
  	repoActions,
  	repoInfo,
  	websiteRepoBranch(config),
  	source,
  	language,
  	issueUrl,
  	)
  	: [{
  	text: language[kRepoActionLinksIssue]!,
  	url: issueUrl!,
  	icon: "chat-right",
  	}];
  	repoTargets.forEach((repoTarget) => {
  	const actionsDiv = doc.createElement("div");
  	actionsDiv.classList.add("toc-actions");
  	const ulEl = doc.createElement("ul");
  	links.forEach((link) => {
  	const a = doc.createElement("a");
  	a.setAttribute("href", link.url);
  	if (linkTarget) {
  	a.setAttribute("target", linkTarget);
  	}
  	if (linkRel) {
  	a.setAttribute("rel", linkRel);
  	}
  	a.classList.add("toc-action");

Fixes #13769

[posit-snyk-bot]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[cderv]

Do we have a test for this already? Otherwise, as other improvement and bug, we need one for regression test. And this is also opportunity to add test for some older feature where we did not add test thoroughly back then.

If you need help adding one, tell me.

This also helps to understand what is trying to be solved or added.

If I understand correctly, the plan is that repo-link-target and repo-link-rel sets for the github links part on each page (https://quarto.org/docs/websites/website-navigation.html#github-links) are also used for the sidebar tools: https://quarto.org/docs/books/book-output.html#sidebar-tools

Did I get it right ?

Looks good otherwise ! Thank you for those improvements!

And we may also take the opportunity for a doc update on the book part about those config being used now

[mcanouil]

I'll add the regexes tests to look for added rel/target.

If I understand correctly, the plan is that repo-link-target and repo-link-rel sets for the github links part on each page (https://quarto.org/docs/websites/website-navigation.html#github-links) are also used for the sidebar tools: https://quarto.org/docs/books/book-output.html#sidebar-tools

Did I get it right ?

Yes, that's the case.

And we may also take the opportunity for a doc update on the book part about those config being used now

The documentation basically says to look for website navigation where the options are described thus umplying that it should have work on the tools buttons in the first place.

• https://quarto.org/docs/books/book-output.html#sidebar-tools

[cderv]

I'll add the regexes tests to look for added rel/target.

You should be able to use the HTML element matching instead of regex.

The documentation basically says to look for website navigation where the options are described thus umplying that it should have work on the tools buttons in the first place.

Yes it says to look at it to customize the repo action "Immediately below the table of contents"

but it does not really say that it works (or should have worked) for link on sidebar

So maybe it is clear enough as it is, but it was not really documented that It should have worked on the tools buttons in the first place. 😉

Anywhow, you're right. maybe this does not need more precision that repo-link-target and repo-link-rel will apply on this sidebar tools too

[mcanouil]

Test added.

[cderv]

Thank you !