-
Notifications
You must be signed in to change notification settings - Fork 385
Upgrade mermaid to 11.12 #13601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade mermaid to 11.12 #13601
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
I followed those instructions. Did I make a mistake? |
I don't think so, it's mostly for future readers. |
|
Fair enough, but I would love if this started a discussion on bumping the version as the current one is fairly old. I'm after a mermaid fix which I can't really get without updating it here. |
Isn't it what #13600 is/was for? As you may know, you can't update all dependencies too frequently. Anyhow thanks for the interest and the PR, the team will decide based on the current priorities and workload, if this update should happen "now" or later. |
|
Thanks so much, @multimeric ! We should be able to take this in. Have you verified that the basic functionality works? We can't really do good automated testing here because it's all visual and image snapshots rot pretty much instantly. I'm just asking so that we have your answer, and then if someone else reports a failure, we'll ask you again before reverting ;) Thanks again, we do truly appreciate the help! |
|
I understand that comprehensively verifying the functionality could be difficult. I can confirm that it at least works for my motivating error case. Source: |
|
I'm ready to merge this, but I'll wait for your changelog edit just so we can make sure you get credit. Thanks again! |


Description
Closes #13600.
Checklist
I have (if applicable):