Skip to content

Conversation

@multimeric
Copy link

Description

Closes #13600.

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR

@posit-snyk-bot
Copy link
Collaborator

posit-snyk-bot commented Oct 23, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@mcanouil
Copy link
Collaborator

@multimeric
Copy link
Author

I followed those instructions. Did I make a mistake?

@mcanouil
Copy link
Collaborator

mcanouil commented Oct 23, 2025

I followed those instructions. Did I make a mistake?

I don't think so, it's mostly for future readers.
This being said, I think the team prefers to do the dependencies updates themselves.

@multimeric
Copy link
Author

Fair enough, but I would love if this started a discussion on bumping the version as the current one is fairly old. I'm after a mermaid fix which I can't really get without updating it here.

@mcanouil
Copy link
Collaborator

Fair enough, but I would love if this started a discussion on bumping the version as the current one is fairly old. I'm after a mermaid fix which I can't really get without updating it here.

Isn't it what #13600 is/was for?

As you may know, you can't update all dependencies too frequently.
You see the lacking features from Mermaid.js but you omit the big picture which is Mermaid.js has to play nicely with all the other dependencies such as Reveal.js, code-annotations, etc. There are already JavaScript conflicts (in particular with Reveal.js) and those are very hard to catch with tests.

Anyhow thanks for the interest and the PR, the team will decide based on the current priorities and workload, if this update should happen "now" or later.

@cderv cderv requested a review from cscheid October 23, 2025 13:21
@cderv
Copy link
Collaborator

cderv commented Oct 23, 2025

We haven't yet done the update for 1.9. Last one was #12939 for v1.8

This seems ok to me but I'll defer to @cscheid for merging this, as he is the one usually doing this update.

@cscheid
Copy link
Collaborator

cscheid commented Oct 23, 2025

Thanks so much, @multimeric ! We should be able to take this in. Have you verified that the basic functionality works?

We can't really do good automated testing here because it's all visual and image snapshots rot pretty much instantly.

I'm just asking so that we have your answer, and then if someone else reports a failure, we'll ask you again before reverting ;)

Thanks again, we do truly appreciate the help!

@multimeric
Copy link
Author

I understand that comprehensively verifying the functionality could be difficult. I can confirm that it at least works for my motivating error case.

Source:

```{mermaid}
flowchart LR
    id1["https://ror.org/01b6kha49"]
    id2["https://schema.org/Organization"]
    id1 --"http://www.w3.org/1999/02/22-rdf-syntax-ns#type"--> id2
```

Quarto 1.8.25:
Screenshot 2025-10-24 at 12 48 48 am

This branch:
Screenshot 2025-10-24 at 12 49 09 am

@cscheid
Copy link
Collaborator

cscheid commented Oct 24, 2025

I'm ready to merge this, but I'll wait for your changelog edit just so we can make sure you get credit. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants