Skip to content

Conversation

emmanuelbernard
Copy link
Member

Will use WebSocket for bidirectional message to and from server
Added a description for Todo for the new UI

Here it is Phillip, I created an new field description for Todo
And created a WebSocket endpoint as /todo-agent/{todoId}

@emmanuelbernard
Copy link
Member Author

@phillip-kruger ^ for the TODO UI

@emmanuelbernard
Copy link
Member Author

@cescoffier is that what you had in mind for the WebSocket?

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have an on message, just remove the onOpen and create the emitter in the onTextMessage.

@emmanuelbernard
Copy link
Member Author

If you have an on message, just remove the onOpen and create the emitter in the onTextMessage.

The reason I created the onTextMessage is that I need a way for the client to send data, with just onOpen that would not be the case right?

Thinking out loud, I could use just onTextMessage and treat the first message as my initializer to discover the todo id. But thaty means the client needs to artificially send me an stupid message to initiate the work. But in the UI, it could be that you start working on things with no chat message for the user, just the "Do with AI" button operation.

@cescoffier
Copy link
Member

My advice when using web socket: See them as TCP connection. So on top of that you need to design and implement a protocol (that's why we often use json rpc on top of web socket in Quarkus as it provides a framing protocol).

In your case I would create a few message type, with a 'kind' attribute to distinguish them.

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos in agent protocol file

Will use WebSocket for bidirectional message to and from server
Added a description for Todo for the new UI
@emmanuelbernard
Copy link
Member Author

Small typos in agent protocol file

Applied your changes @rsvoboda, thanks !

Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger
Copy link
Member

Screencast_20250930_194415.mp4

emmanuelbernard and others added 9 commits September 30, 2025 17:57
To test, go to UI, click on a TODO
then click on Create with AI green button
Then look at stack trace
This simplifies the subscription barrier issues
Use CDI async event to pass info to AgentDispatcher
Create a Context holder for per todoId request after move to
@ApplicationScope
Rename to AgentsMediator (from dispatcher)
Signed-off-by: Phillip Kruger <[email protected]>
@phillip-kruger
Copy link
Member

Screencast_20251003_165042.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants