Following up on pr #9246 5 years later to cleanup

[Sanne]

Follows up on #9246 (review) :
a TODO had been introduced suggesting we should remove this code "soon". .. it's been 5 years and I think we can try doing it... Always good to start some less threads.

[quarkus-bot]

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

• title should not contain an issue number (use Fix #1234 in the description instead)

_{This message is automatically generated by a bot.}

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 57230be.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

❌ org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

• Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError

java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

[gsmet]

Did they change how they do things on the Netty side? Because my recollection is that this one could still be an issue on slow hotel/conference wifi.

[Sanne]

Did they change how they do things on the Netty side?

My understanding is that this was done already when this TODO has been introduced: #9246

They added the log message "just in case" to see if anybody would ever report it, so to have hints to the problem not being fully fixed.