Skip to content

Conversation

@NickBeginner
Copy link
Contributor

This PR fixes 32936

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 00f29ea to 2bc8557 Compare December 1, 2025 21:31
@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Dec 1, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 1, 2025

/cc @gsmet (hibernate-orm)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you'll need to update docs as well, to mention the new component types in that list:

==== Plugging in other custom components
The Quarkus extension for Hibernate ORM will automatically
inject components annotated with `@PersistenceUnitExtension` into Hibernate Search.
The annotation can optionally target a specific persistence unit with `@PersistenceUnitExtension(name = "nameOfYourPU")`.
This feature is available for the following component types:
`org.hibernate.Interceptor`::
See <<interceptors>>.
`org.hibernate.resource.jdbc.spi.StatementInspector`::
See <<statement_inspectors>>.
`org.hibernate.type.format.FormatMapper`::
See <<json_xml_serialization_deserialization>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantResolver`::
See <<multitenancy>>.
`io.quarkus.hibernate.orm.runtime.tenant.TenantConnectionResolver`::
See <<programmatically-resolving-tenants-connections>>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yrodiere i added the new components to the list, but i did not create the pages dedicate to them, is it okay or do you want me also to add the pages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a section dedicated to "Custom functions and types" would make sense, so that it appears in the table of contents and people can easily find how to register those. But you probably don't need detailed explanation beyond one sentence and an example. Does that make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make perfect sense, gonna work on it this weekend. Thanks :)

@NickBeginner NickBeginner changed the title ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor and FunctionContributor Dec 4, 2025
@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 20ae00d to 1579e01 Compare December 7, 2025 20:38
@NickBeginner NickBeginner marked this pull request as ready for review December 7, 2025 20:45
@NickBeginner NickBeginner requested a review from yrodiere December 7, 2025 20:45
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

🎊 PR Preview 98dfb5a has been successfully built and deployed to https://quarkus-pr-main-51323-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 5d74a21 to d2b28c3 Compare December 8, 2025 10:52
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from d2b28c3 to e88912d Compare December 9, 2025 12:37
@quarkus-bot

This comment has been minimized.

@yrodiere
Copy link
Member

yrodiere commented Dec 9, 2025

Hey. You seem to be struggling with formatting -- do you know you can run a single command to have all the code formatted automatically?

./mvnw process-sources

See also https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@NickBeginner NickBeginner force-pushed the nbelcastro/issue-32936 branch from 6ab363b to 11f1506 Compare December 9, 2025 17:56
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 11f1506.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 11f1506.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Maven Tests - JDK 21 Semeru

📦 integration-tests/devmode

io.quarkus.test.devui.DevUIGrpcSmokeTest.testTestService - History

  • Too many recursions, message not returned for id [1131135097] - java.lang.RuntimeException
java.lang.RuntimeException: Too many recursions, message not returned for id [1131135097]
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:175)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:178)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Can you please add that section to the docs, then squash your commits?
After that I think we're good to merge :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a section dedicated to "Custom functions and types" would make sense, so that it appears in the table of contents and people can easily find how to register those. But you probably don't need detailed explanation beyond one sentence and an example. Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow plugging in Hibernate ORM's TypeContributor, FunctionContributor and AdditionalMappingContributor

2 participants