-
Notifications
You must be signed in to change notification settings - Fork 3k
ISSUE-32936 | Allow plugging in Hibernate ORM's TypeContributor and FunctionContributor #51323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
00f29ea to
2bc8557
Compare
|
/cc @gsmet (hibernate-orm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note you'll need to update docs as well, to mention the new component types in that list:
quarkus/docs/src/main/asciidoc/hibernate-orm.adoc
Lines 543 to 561 in 206858a
| ==== Plugging in other custom components | |
| The Quarkus extension for Hibernate ORM will automatically | |
| inject components annotated with `@PersistenceUnitExtension` into Hibernate Search. | |
| The annotation can optionally target a specific persistence unit with `@PersistenceUnitExtension(name = "nameOfYourPU")`. | |
| This feature is available for the following component types: | |
| `org.hibernate.Interceptor`:: | |
| See <<interceptors>>. | |
| `org.hibernate.resource.jdbc.spi.StatementInspector`:: | |
| See <<statement_inspectors>>. | |
| `org.hibernate.type.format.FormatMapper`:: | |
| See <<json_xml_serialization_deserialization>>. | |
| `io.quarkus.hibernate.orm.runtime.tenant.TenantResolver`:: | |
| See <<multitenancy>>. | |
| `io.quarkus.hibernate.orm.runtime.tenant.TenantConnectionResolver`:: | |
| See <<programmatically-resolving-tenants-connections>>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yrodiere i added the new components to the list, but i did not create the pages dedicate to them, is it okay or do you want me also to add the pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a section dedicated to "Custom functions and types" would make sense, so that it appears in the table of contents and people can easily find how to register those. But you probably don't need detailed explanation beyond one sentence and an example. Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make perfect sense, gonna work on it this weekend. Thanks :)
...orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/FastBootMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/FastBootMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...orm/runtime/src/main/java/io/quarkus/hibernate/orm/runtime/boot/FastBootMetadataBuilder.java
Show resolved
Hide resolved
20ae00d to
1579e01
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview 98dfb5a has been successfully built and deployed to https://quarkus-pr-main-51323-preview.surge.sh/version/main/guides/
|
5d74a21 to
d2b28c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d2b28c3 to
e88912d
Compare
This comment has been minimized.
This comment has been minimized.
|
Hey. You seem to be struggling with formatting -- do you know you can run a single command to have all the code formatted automatically? See also https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…tributions" This reverts commit 00f29ea.
6ab363b to
11f1506
Compare
Status for workflow
|
Status for workflow
|
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Can you please add that section to the docs, then squash your commits?
After that I think we're good to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a section dedicated to "Custom functions and types" would make sense, so that it appears in the table of contents and people can easily find how to register those. But you probably don't need detailed explanation beyond one sentence and an example. Does that make sense?

This PR fixes 32936