Use the runtime classloader for test config building #47190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves quarkiverse/quarkiverse#92, which was caused by #34681. It's plausible to me that this could affect other applications and extensions, too.
The symptom is
as triggered from
io.quarkus.test.junit.classloading.QuarkusTestConfigProviderResolver.<init>(QuarkusTestConfigProviderResolver.java:19)
.When the QuarkusTestConfigProviderResolver is initialised, the TCCL is the system classloader, which isn't the friendliest TCCL for downstream classes doing their thing. The System classloader is only used in the
registerConfig
call, so instead of setting an unfriendly TCCL, we can just hardcode the system classloader in that call.