Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Docker and Bazel CIs #628

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Oct 5, 2023

fixes #624
the docker CI failes due to a mismatch between system packages scientific libraries (e.g. numpy) installed by python3-pybind11 and those required by Cirq. Fix by allowing Cirq to override those packages' versions. This is the same as we had before with the --force flag which doesn't seem to work anymore, instead I'm using `a virtualenv


fixes #625
these were broken due to an update to the LLVM library which broke the compilation step https://bugs.llvm.org/show_bug.cgi?id=27310. Fix is to upgrade libc-bin.

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Oct 5, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 5, 2023
@NoureldinYosri NoureldinYosri added the kokoro:run Trigger Kokoro builds for this PR. label Oct 5, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 5, 2023
@NoureldinYosri NoureldinYosri added the kokoro:run Trigger Kokoro builds for this PR. label Oct 17, 2023
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Oct 17, 2023
@NoureldinYosri NoureldinYosri changed the title fix Docker, Bazel and Kokoro CIs fix Docker, Bazel CIs Oct 17, 2023
@NoureldinYosri NoureldinYosri changed the title fix Docker, Bazel CIs fix Docker and Bazel CIs Oct 18, 2023
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks are passing. Thank your @NoureldinYosri for stepping in to resolve these issues!

@NoureldinYosri NoureldinYosri merged commit 148a9c6 into quantumlib:master Oct 18, 2023
14 checks passed
@NoureldinYosri NoureldinYosri deleted the fix_ci branch October 18, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants