DisARM qsim #530
Merged
DisARM qsim #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
approved these changes
May 13, 2022
It seems likely that there's something for this, but singling out a specific wheel for a specific architecture requesting it might get finicky. I'll add a note to the issue to see if we can flag this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #495, qsim wheels are not compatible with MacOS M1. This PR removes the
universal2wheels from the test and release workflows so that M1s do not install a known-invalid wheel.Some complications will persist: M1s could still install wheel published for older qsim versions, and building qsim from source is also broken on M1 devices. However, this at least stops us from continuing to advertise a functioning ARM-compatible qsim wheel in subsequent releases.