Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate simd compilation units #378

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Separate simd compilation units #378

merged 5 commits into from
Jul 19, 2021

Conversation

laurynasas
Copy link
Contributor

This is work targeting issue in #361.

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label Jul 14, 2021
@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Jul 16, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jul 16, 2021
95-martin-orion
95-martin-orion reviewed Jul 16, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems alright to me, given that the majority of tests are still passing. The Docker failure seems like it might be a linking issue? Since now pybind_main.cpp only makes sense in the context of one of the pybind_main_* files.

@laurynasas
Copy link
Contributor Author

right, that's correct, fixed this, PTAL

@95-martin-orion 95-martin-orion added the kokoro:run Trigger Kokoro builds for this PR. label Jul 19, 2021
@qsim-qsimh-bot qsim-qsimh-bot removed the kokoro:run Trigger Kokoro builds for this PR. label Jul 19, 2021
@95-martin-orion 95-martin-orion merged commit efbde66 into quantumlib:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

Assignees
No one assigned
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurynasas @95-martin-orion @qsim-qsimh-bot