Skip to content

Support Cirq 1.5 #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Support Cirq 1.5 #1723

wants to merge 3 commits into from

Conversation

mpharrigan
Copy link
Collaborator

towards #1708 -- things are still broken with cirq 1.6

towards #1722 -- I pin numpy and do one easy test fix for this

mhucka
mhucka approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@mhucka mhucka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I pulled the branch to a local linux machine for testing, and it passes pytest and other tests.

Note that there's a failing format test in CI. Looks pretty trivial, but it would still be best to fix it before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhucka mhucka mhucka approved these changes

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpharrigan @mhucka