Add Decomposition of ECWindowAddR #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fpapa250
commented
Oct 24, 2024
fpapa250
commented
- Adds working decomposition of ECWindowAddR (with classical simulation tests compatible with existing APIs)
- Updates higher level bloqs to have window size args for modular multiplication and windowed EC Add
- Temporary int() casting all over because upper level bloqs and APIs (QMontgomeryUInt functions) only accept ints and not SymbolicInts (tagged in issue: Change all integer arguments in FindECCPrivateKey bloq (and downstream bloqs) to SymbolicInt #1476, will fix in future PR)
| R: ECPoint | ||
| add_window_size: int | ||
| mul_window_size: int = 1 |
There was a problem hiding this comment.
a window size of 1 means normal multiplication, no?
mpharrigan
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.