Open
Conversation
- Replaced `start_new_session=True` with `creationflags=subprocess.CREATE_NO_WINDOW` on Windows for spawning workers. - Addressed `os.kill(..., signal.SIGTERM)` on Windows by using `taskkill /F /T /PID`. - Handled Windows SIGTERM emulation in daemon utilizing `signal.SIGBREAK` where available. - Modified files: `embeddings.py`, `worker_pool.py`, `reranker.py`, `daemon.py`, and `commands.py`. Co-authored-by: Tyrin451 <223395+Tyrin451@users.noreply.github.com>
Tyrin451
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, I'm not expert at all with all this subprocess child (across multiple platform).
But finally I managed to fix with some AI help.
I try to run the test, i have 75 tests which fail (may be it's ok because lot of windows side effects remaining).
Feel free to discard this PR or get inspired by the modification. I can also try to improve the modification.