Skip to content

Conversation

@francescmaestre
Copy link

@francescmaestre francescmaestre commented Jul 4, 2025

Describe your changes

Adding GitQlient plugin to the extension registry.

Checklist

@francescmaestre francescmaestre requested a review from a team as a code owner July 4, 2025 09:09
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2025

CLA assistant check
All committers have signed the CLA.

@Maddimax
Copy link
Contributor

Maddimax commented Jul 4, 2025

Thank you very much for your contribution! We are still not quite done with all the legalese, but as soon as that is done we will merge your request.

@lavonardo
Copy link

Thank you for your submission and apologies to have kept you waiting.
With the incoming release of Qt Creator 18, we will be merging the pull request, and thus GitQlient will be available in the extension directory.
However, as your extension is written in C++ and thus dependent on the version of Qt Creator, could you please update the pull request to refer to versions that have been built against Qt Creator 18.

@francescmaestre
Copy link
Author

I'll try to do it during the week, thanks!

@francescmaestre francescmaestre force-pushed the main branch 3 times, most recently from 27c1dd9 to 9b4ad82 Compare November 2, 2025 07:41
@francescmaestre francescmaestre force-pushed the main branch 3 times, most recently from 16e9615 to 09c184c Compare November 2, 2025 09:13
@francescmaestre
Copy link
Author

@lavonardo @Maddimax After some wrestling with the SSH keys I finally manage to sign commits again.

I've updated the new SHAs for the plugin and the names/IDs inside. Thanks for the review!

@francescmaestre
Copy link
Author

@lupax is this something you could also take a look?

@cristianadam
Copy link
Member

We have noticed that we have a showstopper with the legalese. If you have a look at 9. of Qt Creator Extensions Store Publisher Terms you would see:

  1. License to Users: All Extensions must be licensed under the terms of either the MIT license, the BSD license, or the Apache license. You are responsible for clearly specifying the license terms under which you offer your Extensions to users. Unless otherwise explicitly agreed in writing between You and The Qt Company, Your Extension constitutes Third-Party Software under the commercial contract(s) between The Qt Company and its Customers.

@lavonardo any follow up in this regard?

@francescmaestre
Copy link
Author

I see that now @cristianadam. Although I hold the license of GitQlient and it's plugin there are some files I need to remove to be able to change it since they are from another project.

In any case, I'd have to take a look to those MIT/BSD/Apache licenses since just changing it for QtCreator is a no-go. Specially with the user base it has.

A different story would be if QtCreator would support LGPL3 licenses, or similar where linking is allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants