[5016][UPD] mrp_subcontracting_skip_no_negative

[kanda999]

5016
Reflect OCA updates

[yostashiro]

@kanda999 It wasn't clear to me whether negative stock would really be created before this update. Can you please confirm on this point?

[yostashiro]

Does this handle the following scenario well?

Process a receipt picking with the following content:

• Subcontracted product: demand x2, done x1
• Normal product: demand x2, done x1

Generated backorder picking:

• Subcontracted product: demand x1
• Normal product: demand x1

Looking at the code, I suppose it works in this manner. Please confirm.

If it works OK, please add comments explaining the design rationale.

[yostashiro]

I guess the current code doesn't handle the case well where partial receipt is processed for a picking which only contains subcontracted products.

Suggested change

	moves_with_check = self - moves_with_no_check
	res = super(StockMove, moves_with_check.with_context(no_backorder=True))._action_done(
	# Assign `no_backorder=True` context to the first batch of moves for _action_done()
	# to avoid generation of a backorder during the process, in case there are two batches
	# of moves (with negative check and without) to be processed in _action_done().
	if moves_with_no_check != self:
	moves_with_no_check = moves_with_no_check.with_context(no_backorder=True)
	res = super(StockMove, moves_with_no_check)._action_done(
	cancel_backorder=cancel_backorder
	)
	res += super(StockMove, self - moves_with_no_check)._action_done(
	cancel_backorder=cancel_backorder
	)