Conversation
706f87f to
b247ebc
Compare
Contributor
|
This part cause the tests CI failed. axls-oca/auditlog/tests/test_auditlog.py Lines 632 to 707 in 9958714 This is the reason of the issue and I am finding the way to fix. axls-oca/auditlog/tests/test_auditlog.py Line 658 in 9958714 |
Contributor
|
I'm going to fix the CI issue. |
Contributor
|
I checked the root cause and I found the calling write() from test cases of base_user_role is not executed from extend write() method of base_user_role and just directly calls to write() of base module if we use together with auditlog. axls-oca/auditlog/models/rule.py Line 209 in 9958714 |
b247ebc to
31e3302
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4913