[4613][ADD] quality_control_oca, quality_control_stock_oca#139
Open
yostashiro wants to merge 13 commits into16.0from
Open
[4613][ADD] quality_control_oca, quality_control_stock_oca#139yostashiro wants to merge 13 commits into16.0from
yostashiro wants to merge 13 commits into16.0from
Conversation
This was referenced Jun 10, 2024
yostashiro
force-pushed
the
4613-add2-quality_control_stock_oca
branch
4 times, most recently
from
c1f0c4c to
3e47632
Compare
…or confirmed moves This commit adds the timing field in the QC trigger line to enable following scenarios: - When timing is 'Before', an inspection is generated wfor each related move when a picking with the trigger is confirmed. - When timing is 'Plan Ahead', a 'Plan' inspection is generated for each related move when a picking with the trigger is confirmed. A plan inspection is just a plan, and cannot be updated except for the date. A plan inspection gets converted into an executable inspection once the picking is done.
yostashiro
force-pushed
the
4613-add2-quality_control_stock_oca
branch
from
3e47632 to
d87bfa4
Compare
AungKoKoLin1997
approved these changes
Jun 12, 2024
Contributor
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
Code Review: LGTM
yostashiro
force-pushed
the
4613-add2-quality_control_stock_oca
branch
from
924bf9b to
766dd03
Compare
Member
Author
|
Wasn't sure the approach of the last commit to avoid the CacheMiss error was the correct one. @AungKoKoLin1997 Can you please help check. I was getting errors of the following kind from |
Comment on lines
+68
to
+69
| res = super()._action_confirm(merge=merge, merge_into=merge_into) | ||
| for move in self: |
Contributor
There was a problem hiding this comment.
@yostashiro I understand the intention of using @lru_cache() decorator for get_qc_trigger.
But I still don't understand why we can't use for move in res instead of checking picking_type_id in cache.
I think using confirmed moves instead of self is more structured and avoid unnecessary issues.
kanda999
approved these changes
Jul 3, 2024
kanda999
force-pushed
the
4613-add2-quality_control_stock_oca
branch
from
4f1a390 to
0ed43b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4613
Supersedes #136 and #137.