Open
Conversation
yostashiro
approved these changes
Mar 10, 2026
Member
yostashiro
left a comment
There was a problem hiding this comment.
I'm not in favor of increasing the method args, though. I think there is probably a cleaner way.
Contributor
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
In my opinion, the fix can be done by adjusting two or three lines.
Inside _get_line_analytic_account use if line.account_id.code != account_code instead of if is_substituted. Then, just pass account_code parameter from _update_vals when you call _get_line_analytic_account. Or, you can get rid of adding extra _get_line_analytic_account and add above condition inside _update_vals like below.
if line.account_id.code != account_code:
project = self.env["account.analytic.account"]
department = self.env["account.analytic.account"]
else:
project = line.analytic_line_ids.filtered(
lambda x: x.plan_type == "project"
).account_id[:1]
department = line.analytic_line_ids.filtered(
lambda x: x.plan_type == "department"
).account_id[:1]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6424