[6114][IMP] product_plm_import: set lot sequence prefix from ESC ID on product creation#140
Open
nobuQuartile wants to merge 4 commits into16.0from
Open
[6114][IMP] product_plm_import: set lot sequence prefix from ESC ID on product creation#140nobuQuartile wants to merge 4 commits into16.0from
nobuQuartile wants to merge 4 commits into16.0from
Conversation
nobuQuartile
force-pushed
the
6114-imp-product_plm_import
branch
3 times, most recently
from
435b393 to
eadd28c
Compare
… sequence prefix
Allow lot_sequence_prefix in plm.product.mapping to reference the PLM
record's ESC ID via '{esc_code}' placeholder (e.g. '{esc_code}').
This enables per-product prefix resolution at creation time.
- Add constrains on lot_sequence_prefix to raise ValidationError when the format string is invalid (e.g. unknown placeholder) - Fix return -> continue in _send_plm_import_notification() so records without notified partners do not skip remaining records - Clarify _create_product() to explicitly return on both success and failure paths
nobuQuartile
force-pushed
the
6114-imp-product_plm_import
branch
from
eadd28c to
53b26b4
Compare
nobuQuartile
force-pushed
the
6114-imp-product_plm_import
branch
from
ac06dc2 to
d475ecc
Compare
- Add constrains on lot_sequence_prefix to raise ValidationError when the format string is invalid (e.g. unknown placeholder) - Fix return -> continue in _send_plm_import_notification() so records without notified partners do not skip remaining records - Clarify _create_product() to explicitly return on both success and failure paths - Add tests for lot_sequence_prefix validation and create_products() prefix resolution from ESC ID
nobuQuartile
force-pushed
the
6114-imp-product_plm_import
branch
from
d475ecc to
cba6d4d
Compare
yostashiro
approved these changes
Mar 3, 2026
product_plm_import/tests/__init__.py
Outdated
Comment on lines
+1
to
+3
| # Copyright 2026 Quartile Limited | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| # Copyright 2026 Quartile Limited | |
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). |
AungKoKoLin1997
approved these changes
Mar 4, 2026
Contributor
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
There was a problem hiding this comment.
Code Review: LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6114