support a new MCU:FS026. add a new keyboard:essemi/fs026.

[liuhy-2020]

support a new MCU:FS026.
add a new keyboard:essemi/fs026.

Need to update ChibiOS-Contrib(Merged PR:ChibiOS/ChibiOS-Contrib#397)

Description

Types of Changes

• [v] Core
• Bugfix
• New feature
• Enhancement/optimization
• [v] Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• [v] My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• [v] My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• [v] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[tzarc]

Half of my review comments on the previous PR still apply.
#23233 (review)

[tzarc]

Also, why are things ES32 as well as FS026? Should the MCU actually be called ES32FS026, much like this? Why are you using ES32 if it's been renamed?

[liuhy-2020]

The MCU library I am using comes from ES32_SDK.
In ES32_SDK, the MCU is referred to as ES32F0283_FS026.
ES32F0283 and FS026 are different MCUs. I can find them all in the chip package. The majority of peripherals used in ES32F0283 and FS026 are the same. But the resources are different.

[liuhy-2020]

The reason for QMK CI Build failure is that ChibiOS Contrib has not been updated to the latest version.

next step： add a corresponding test board under keyboards/handwired/onekey?

[liuhy-2020]

@tzarc Is it convenient to update ChibiOS Contrib? (FS026 merged into ChibiOS Contrib last week)

[tzarc]

CI disabled until we update ChibiOS-Contrib -- #23405.

[liuhy-2020]

CI disabled until we update ChibiOS-Contrib -- #23405.

When will the ChibiOS-Contrib be updated approximately?

[tzarc]

When will the ChibiOS-Contrib be updated approximately?

Already done.

[tzarc]

After everything has been applied, the only changes in this PR should be under keyboards/essemi. No other files need to be modified at this stage.

[tzarc]

More changes.

[tzarc]

These are written as TIM1...TIM4, but the backlight is called GP16C4T2.
The defines don't match https://github.com/ChibiOS/ChibiOS-Contrib/blob/chibios-21.11.x/os/hal/ports/ES32/LLD/TIMv1/hal_pwm_lld.h

Please fix up this file so that ALL item names are actually correct, not just the PWM ones.

[liuhy-2020]

What modifications are needed?

[tzarc]

What modifications are needed?

Your mcuconf.h is now in the wrong format and only configures PWM entries, but should be configuring every available peripheral. You also have not addressed the issue with the readme.

[liuhy-2020]

If the MCU driver currently only supports GPIO, USB, and PWM functions. Is this okay?

In the future, improve MCU drivers.

[tzarc]

This is what a normal mcuconf.h would look like for a typical Chinese STM32 clone: https://github.com/qmk/qmk_firmware/blob/master/platforms/chibios/boards/GENERIC_WB32_F3G71XX/configs/mcuconf.h

Note that it includes all peripheral types. This is the expectation, even if they're not yet implemented in ChibiOS-Contrib.

I understand you've only implemented the bare minimum in the base layer, but we don't want to be modifying and adapting these files every time you onboard a new peripheral.

As it stands the only peripheral you have added is PWM, so technically the default should be that USB and GPIO are disabled and your keyboard shouldn't work. As such, we'll assume you've misconfigured your code in ChibiOS-Contrib if they're working without being configured. Might be best fixing that up -- peripherals should be disabled by default in the base layer.

[liuhy-2020]

OK.I will add all peripherals in mcuconf. h.

[zvecr]

Please stop pinging tzarc, and take note of the message we use on Discord.

While we know that your PR is important to you, it may take some time for QMK collaborators to get to it.

PR reviews are something that is done in their free time -- collaborators are not paid nor compensated for the time spent reviewing, as it is a labor of love. As such, this means that it can take time for them to get to your PR -- things like family, or life can get in the way of finding time to perform reviews, and burnout is a serious consideration. The QMK firmware repository averages 300 PRs opened and 300 PRs merged every month, so please have patience.

[liuhy-2020]

ok

[github-actions]

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

[github-actions]

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]