Implement up-to-phase algorithm #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the algorithm that allows synthesizing the z-rotation up to a global phase.
Closes #9.
This extends John's PR #11 based on the
pygridsynthimplementation (to which John also significantly contributed).Should be rebased on top of #30.
At the moment this is slightly suboptimal. Instead of gradually increasing k and running exact and shifted synthesis for this k until one of the two finds a solution, we actually run both decompositions and only at the end pick the one with the fewest gates.
There are also a few cleanups to do: I may have added too many clones and temporarily disabled some of the timing data.