Add tests #60
Merged
Add tests #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Added an issue for the first bullet point #63 |
Collaborator
|
The mirror RB failing is not a surprise, I think it's an open issue |
Collaborator
|
Can you resolve the readme conflicts then I'll merge |
Collaborator
Author
This PR may fix the issue: #46. In any case, the tests should now be able to validate if it does or not. |
dcmckayibm
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for a few custom experiments and circuit creation functions. Currently uses fake backends with small parameter inputs to validate that the end-to-end flow works as expected.
This method can be extended to some of the helper functions used for CLOPS and Mirror. It could also be valuable to use qiskit-aer with some sort of randomization seed to validate that the result value without noise for benchmarks is correct, that way we can ensure that these benchmarks are calculated correctly.
The tests found a few errors that should be addressed in following PRs:
analysis_resultsis called, which is incorrectThe content of these tests (and parameters) should be double-checked for validity.