improve (security): simplify set boolean value

qiscus · Jan 21, 2025 · e8dd6e0 · e8dd6e0
1 parent 3a26c0b
commit e8dd6e0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/chat-core/src/main/java/com/qiscus/sdk/chat/core/data/local/QiscusDataManagement.java b/chat-core/src/main/java/com/qiscus/sdk/chat/core/data/local/QiscusDataManagement.java
@@ -250,7 +250,7 @@ public static String set(Integer value) {
 
     public static String set(Boolean value) {
         if (value == null) return null;
-        return encrypt(String.valueOf(value));
+        return encrypt(String.valueOf(value ? 1 : 0));
     }
 
     public static String set(String value) {

diff --git a/chat-core/src/main/java/com/qiscus/sdk/chat/core/data/local/QiscusDb.java b/chat-core/src/main/java/com/qiscus/sdk/chat/core/data/local/QiscusDb.java
@@ -77,13 +77,13 @@ static ContentValues toContentValues(QiscusChatRoom qiscusChatRoom) {
             values.put(COLUMN_DISTINCT_ID, qiscusChatRoom.getDistinctId());
             values.put(COLUMN_UNIQUE_ID, qiscusChatRoom.getUniqueId());
             values.put(COLUMN_NAME, set(qiscusChatRoom.getName()));
-            values.put(COLUMN_IS_GROUP, set(qiscusChatRoom.isGroup() ? 1 : 0));
+            values.put(COLUMN_IS_GROUP, set(qiscusChatRoom.isGroup()));
             values.put(COLUMN_OPTIONS, set(
                     qiscusChatRoom.getOptions() == null ? null : qiscusChatRoom.getOptions().toString())
             );
             values.put(COLUMN_AVATAR_URL, set(qiscusChatRoom.getAvatarUrl()));
             values.put(COLUMN_UNREAD_COUNT, set(qiscusChatRoom.getUnreadCount()));
-            values.put(COLUMN_IS_CHANNEL, set(qiscusChatRoom.isChannel() ? 1 : 0));
+            values.put(COLUMN_IS_CHANNEL, set(qiscusChatRoom.isChannel()));
             values.put(COLUMN_MEMBER_COUNT, set(qiscusChatRoom.getMemberCount()));
             return values;
         }
@@ -289,8 +289,8 @@ static ContentValues toContentValues(QiscusComment qiscusComment) {
             values.put(COLUMN_SENDER_AVATAR, set(qiscusComment.getSenderAvatar()));
             values.put(COLUMN_TIME, qiscusComment.getTime().getTime());
             values.put(COLUMN_STATE, set(qiscusComment.getState()));
-            values.put(COLUMN_DELETED, set(qiscusComment.isDeleted() ? 1 : 0));
-            values.put(COLUMN_HARD_DELETED, set(qiscusComment.isHardDeleted() ? 1 : 0));
+            values.put(COLUMN_DELETED, set(qiscusComment.isDeleted()));
+            values.put(COLUMN_HARD_DELETED, set(qiscusComment.isHardDeleted()));
             values.put(COLUMN_TYPE, set(qiscusComment.getRawType()));
             values.put(COLUMN_PAYLOAD, set(qiscusComment.getExtraPayload()));
             values.put(COLUMN_EXTRAS, set(