fix(framegen): avoid Qualcomm decoder surface crashes - #471
Draft
qiin2333 wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qiin2333
force-pushed
the
master
branch
2 times, most recently
from
August 25, 2026 03:00
85b5eb3 to
a4d7ce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
OMX.qcom.*/c2.qti.*解码器从configure()开始就直接输出到帧生成ImageReader,不再运行时调用setOutputSurface(),这只厂商驱动小杂鱼就没机会在 Java 调用成功后偷偷把进程炸掉啦。SurfaceView解码,避免“解码帧在跑、屏幕却黑着”的尴尬状态。为啥要改
Issue #452 的 Retroid Pocket 5(Snapdragon 865 / Adreno 650)在 HEVC HDR 帧生成预热完成、解码器动态切换到
ImageReader后直接重启进程,没有 JavaFATAL EXCEPTION。日志表明厂商解码器接受MediaCodec.setOutputSurface()后异步 native 崩溃,Java 层无法捕获。Refs #452。
验证
./gradlew :app:testNonRootDebugUnitTest --tests com.limelight.binding.video.MediaCodecDecoderRendererTest :app:assembleNonRootDebugOMX.qcom.video.decoder.hevc,日志出现dynamic switch disabled,连续收到 480 帧 AHB,测试期间 PID 保持不变且无 native 崩溃。VK_ERROR_FEATURE_NOT_PRESENT (-8)失败;新增回退路径成功触发并恢复普通解码。完整插帧仍需由 [Bug]: Frame Gerenation crash on Retroid Pocket 5 #452 用户在预热可成功的 Retroid Pocket 5 上验证。