Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server empty values in highlight labels parameters #60180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mhugent
Copy link
Contributor

@mhugent mhugent commented Jan 17, 2025

If a highlight feature does not have a label, HIGHLIGHT_LABEL_XXX Parameters can be empty, e.g. 'HIGHLIGHT_LABELSTRING=feature1;;feature3'. In the past, empty entries have been discarded when parsing the entry to a list, resulting in assigning the properties to the wrong highlight features. This has been fixed for GetMap and HIGHLIGHT_LABEL_STRING (see #56729), but not for GetPrint and the other label parameters.

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 3739adf)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 3739adf)

Copy link

github-actions bot commented Jan 17, 2025

Tests failed for Qt 6

One or more tests failed using the build from commit 3739adf

WMS_GetPrint_Highlight_Empty_Labels

WMS_GetPrint_Highlight_Empty_Labels

Test failed at test_wms_getprint_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getprint.py:557

Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetPrint_Highlight_Empty_Labels/WMS_GetPrint_Highlight_Empty_Labels.png (found 15210 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Copy link

Tests failed for Qt 5

One or more tests failed using the build from commit a4d1154

WMS_GetPrint_Highlight_Empty_Labels

WMS_GetPrint_Highlight_Empty_Labels

Test failed at test_wms_getprint_highlight_empty_labels at tests/src/python/test_qgsserver_wms_getprint.py:557

Rendered image did not match tests/testdata/control_images/qgis_server/WMS_GetPrint_Highlight_Empty_Labels/WMS_GetPrint_Highlight_Empty_Labels.png (found 9857 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant