Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default snapping options in georeferencer #60179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

3nids
Copy link
Member

@3nids 3nids commented Jan 17, 2025

@lbartoletti Here you go, follow-up from #60156

I'm just not sure this is the right approach. If someone messes with these values, the tool becomes unusable and you have no idea why.
Looking at other places in the code, it doesn't seem to be much used where it cannot be altered.
And I think adding a GUI to play with snapping tolerance in the georeferencer window is an overkill.

@3nids 3nids requested a review from lbartoletti January 17, 2025 07:50
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 1f530b6)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 1f530b6)

Copy link
Member

@lbartoletti lbartoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok for me

@3nids
Copy link
Member Author

3nids commented Jan 17, 2025

@lbartoletti so you would prefer to merge this rather than hardcoding the tolerance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants