fixed wfs-connection triggering ssl-error response leading to crash #60176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When WFS connection fails during issuing connection request - opening/expanding connection-to-be-layer in the layer tree leads to the crash.
This is happening because the function,
QgsBaseNetworkRequest::issueRequest
that issues request, does not disconnect its local implementation from global singleton-emitted signals, leaving it hanging and reacting to it, when the local implementation/data is already gone (local mutex and waitCondition are destroyed on exiting function, but lambda-function, that uses them - resumeMainThread - reacts to the signal(s) through hanging connection(s) and tries to use them).
Thus explicit disconnects are provided to prevent this situation.