Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wfs-connection triggering ssl-error response leading to crash #60176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

notguiltyspark
Copy link
Contributor

Description

When WFS connection fails during issuing connection request - opening/expanding connection-to-be-layer in the layer tree leads to the crash.

This is happening because the function,

QgsBaseNetworkRequest::issueRequest

that issues request, does not disconnect its local implementation from global singleton-emitted signals, leaving it hanging and reacting to it, when the local implementation/data is already gone (local mutex and waitCondition are destroyed on exiting function, but lambda-function, that uses them - resumeMainThread - reacts to the signal(s) through hanging connection(s) and tries to use them).

Thus explicit disconnects are provided to prevent this situation.

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit c47bb84)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit c47bb84)

@rouault
Copy link
Contributor

rouault commented Jan 17, 2025

@notguiltyspark good catch! Would you mind applying the same type of change in src/core/network/qgsblockingnetworkrequest.cpp ? (yes, in an ideal world we wouldn't have that kind of duplicated code...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants