Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QgsVectorFileWriterMetadataContainer: remove FileGDB (SDK based) driver from proposed list if GDAL >= 3.11 #60165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

QgsVectorFileWriterMetadataContainer: remove FileGDB (SDK based) driver from proposed list if GDAL >= 3.11 #60165

wants to merge 1 commit into from

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Jan 15, 2025

In GDAL 3.11, write support of the FileGDB driver will go through the OpenFileGDB one, so no need to propose it and confuse users. Cf OSGeo/gdal#11662

@rouault
QgsVectorFileWriterMetadataContainer: remove FileGDB (SDK based) driv…
e3477b8 
…er from proposed list if GDAL >= 3.11

In GDAL 3.11, write support of the FileGDB driver will go through the
OpenFileGDB one, so no need to propose it and confuse users.
Cf OSGeo/gdal#11662
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 15, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e3477b8)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e3477b8)

@agiudiceandrea
Copy link
Contributor

Should this be backported to 3.40 (in case GDAL/OGR 3.11 will be released before the last QGIS 3.40.x release in Jan 2026)?

@rouault
Copy link
Contributor Author

rouault commented Jan 16, 2025

Should this be backported to 3.40 (in case GDAL/OGR 3.11 will be released before the last QGIS 3.40.x release in Jan 2026)?

No strong opinion. One might consider that a breaking change for a stable branch (e.g. if people have selected that driver as their default driver), although that wouldn't be really terribly "breaking". Having the FileGDB option with GDAL 3.11 will not hurt. It should still be functional, as the driver will redirect to the OpenFileGDB one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbruy alexbruy alexbruy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.42.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rouault @agiudiceandrea @alexbruy