Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add abstractrenderview #60159

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

benoitdm-oslandia
Copy link
Contributor

This PR is part of qgis/QGIS-Enhancement-Proposals#259 QEP (relates to qgis/QGIS-Enhancement-Proposals#252).

It introduces the AbstractRenderview concept to split the framegraph into a more modular way.

As many files will be introduced, we move all framegraph related files in a new subdirectory framegraph.

As examples, we extracted 3 renderviewes: one for the 3dAxis, one for the forward and one for the shadows.

cc @ptitjano @mkrus

Funded by CEA/DAM @renardf

@benoitdm-oslandia benoitdm-oslandia self-assigned this Jan 15, 2025
@benoitdm-oslandia benoitdm-oslandia added the 3D Relates to QGIS' 3D engine or rendering label Jan 15, 2025
@github-actions github-actions bot added this to the 3.42.0 milestone Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e86f599)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e86f599)

benoitdm-oslandia and others added 10 commits January 15, 2025 17:25
rename QgsFramegraphUtils to QgsFrameGraphUtils
…class

feat(3daxis): move camera creations into render view

fix(qgs3daxissettings): add checks in readXml to avoid disabled axis view

When the project is saved in an old version, minViewportRatio or maxViewportRatio can have
bad saved data (ie. 0 values) leading to always disable axis view.
…w class

feat(3d/shadow): move shadow setting updates from qgs3dmapscene into render view
@benoitdm-oslandia benoitdm-oslandia force-pushed the feat/add_abstractrenderview branch from 18fac38 to c665d88 Compare January 15, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D Relates to QGIS' 3D engine or rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant