-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add abstractrenderview #60159
Open
benoitdm-oslandia
wants to merge
12
commits into
qgis:master
Choose a base branch
from
benoitdm-oslandia:feat/add_abstractrenderview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/add abstractrenderview #60159
benoitdm-oslandia
wants to merge
12
commits into
qgis:master
from
benoitdm-oslandia:feat/add_abstractrenderview
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
rename QgsFramegraphUtils to QgsFrameGraphUtils
Co-authored-By: Mike Krus <[email protected]>
…class feat(3daxis): move camera creations into render view fix(qgs3daxissettings): add checks in readXml to avoid disabled axis view When the project is saved in an old version, minViewportRatio or maxViewportRatio can have bad saved data (ie. 0 values) leading to always disable axis view.
…w class feat(3d/shadow): move shadow setting updates from qgs3dmapscene into render view
benoitdm-oslandia
force-pushed
the
feat/add_abstractrenderview
branch
from
January 15, 2025 16:27
18fac38
to
c665d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of qgis/QGIS-Enhancement-Proposals#259 QEP (relates to qgis/QGIS-Enhancement-Proposals#252).
It introduces the
AbstractRenderview
concept to split the framegraph into a more modular way.As many files will be introduced, we move all framegraph related files in a new subdirectory
framegraph
.As examples, we extracted 3 renderviewes: one for the 3dAxis, one for the forward and one for the shadows.
cc @ptitjano @mkrus
Funded by CEA/DAM @renardf