Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include/exclude in QgsRange #60139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Djedouas
Copy link
Member

@Djedouas Djedouas commented Jan 14, 2025

Description

fix QgsRange::overlaps()

When comparing 2 QgsRange objects for overlap, only the first include/exclude limits restrictions were considered.

This leads to errors like this, where range1.overlaps(range2) != range2.overlaps(range1):

<QgsIntRange: [4, 8)>   # left end not included
<QgsIntRange: [8, 10)>  # left end not included
r1 overlaps r2: False
r2 overlaps r1: True

<QgsIntRange: (4, 8)>  # both ends included
<QgsIntRange: [8, 10]>  # left end not included
r1 overlaps r2: False
r2 overlaps r1: True

fix time limits include/exclude for vector layer properties

In fixed mode the include/exclude limits parameter was not used (always considered include both).


Funded by CNES

@github-actions github-actions bot added this to the 3.42.0 milestone Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit ad7596f)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit ad7596f)

…n fixed mode

For vector layers.

When temporal range is in fixed mode, include/exclude end is not
considered (always included).

In other temporal range modes, a QGIS expression is constructed which
already takes it into account.
@Djedouas Djedouas force-pushed the fix-exclude-end-temporal-range branch from 53fb055 to ad7596f Compare January 14, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant