Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to query larger tiles than the default max size with stepWidth/… #60031

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

mhugent
Copy link
Contributor

@mhugent mhugent commented Dec 31, 2024

QgsWMSCapabilities has mMaxWidth/mMaxHeight as the server width/height limit and mStepWidth/mStepHeight as raster size to iterate the layer. After commit 2078ef5#diff-d88af508cce11c2b59f0ad9c1ddb29824f7cce111807af3289eec2663930e39e , it is not possible anymore to make GetMap-Requests with step sizes larger than the default maximum tile size (2000x2000). This PR makes a small change to take the step width as size limit if there is no size limit set.

…stepHeight in case the WMS does not have a max tile size constraint
@mhugent mhugent requested a review from elpaso December 31, 2024 08:08
@github-actions github-actions bot added this to the 3.42.0 milestone Dec 31, 2024
Copy link

github-actions bot commented Dec 31, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 9bb5cd0)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 9bb5cd0)

@agiudiceandrea
Copy link
Contributor

Is the description of the "Request step size" parameter at https://docs.qgis.org/3.40/en/docs/user_manual/working_with_ogc/ogc_client_support.html#loading-wms-wmts-layers enough accurate or should/could it be enhanced in order to better clarify the exact behaviour?

@mhugent
Copy link
Contributor Author

mhugent commented Dec 31, 2024

Is the description of the "Request step size" parameter at https://docs.qgis.org/3.40/en/docs/user_manual/working_with_ogc/ogc_client_support.html#loading-wms-wmts-layers enough accurate or should/could it be enhanced in order to better clarify the exact behaviour?

I think the description is accurate enough

@jeroenstijven
Copy link

@mhugent, @elpaso , are you and other people from the QGIS community doing all the communication in github, or also at "Element" communication application?
Because i am working on a new project for more data security with gps and blockchain.

Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 16, 2025
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Jan 23, 2025
@agiudiceandrea agiudiceandrea removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 23, 2025
@mhugent mhugent merged commit 55c975c into qgis:master Jan 27, 2025
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants