Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix running gdal algs with virtual layers #59985

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix running gdal algs with virtual layers #59985

wants to merge 5 commits into from

Conversation

NyakudyaA
Copy link
Contributor

@NyakudyaA NyakudyaA commented Dec 20, 2024 •
edited
Loading

Fixes #59364, #39138

Resurrects #59465

@github-actions github-actions bot added this to the 3.42.0 milestone Dec 20, 2024
@NyakudyaA NyakudyaA changed the title fix running algs with virtual layers fix running gdal algs with virtual layers Dec 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit ba89129)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit ba89129)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 5, 2025
@NyakudyaA
Copy link
Contributor Author

not stale

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jan 6, 2025
elpaso
elpaso reviewed Jan 8, 2025
View reviewed changes
python/plugins/processing/algs/gdal/Buffer.py
@@ -134,8 +134,15 @@ def getConsoleCommands(self, parameters, context, feedback, executing=True):
source_details = self.getOgrCompatibleSource(
self.INPUT, parameters, context, feedback, executing
)
if not source_details.layer_name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes (and all the others below, except the virtual layers part) related to the PR title "fix running gdal algs with virtual layers" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.42.0
Development

Successfully merging this pull request may close these issues.

Using virtual layer gives error in GDAL processing algorithms
2 participants
@NyakudyaA @elpaso