Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task to update news bar #454

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Oct 4, 2024

Fix for #445 and proposed fix according to #445 (comment)

image

@Xpirix Xpirix requested a review from timlinux October 4, 2024 06:25
@timlinux
Copy link
Member

timlinux commented Oct 7, 2024

LGTM - automation with gh would be great.

@anitagraser CC for you - hopefully this explains how to add a news banner to the site now.

@timlinux timlinux merged commit 98d23cd into qgis:main Oct 7, 2024
2 checks passed
@anitagraser
Copy link
Member

So to summarize: whenever the website is built, the last entry from the feed is fetched and displayed?

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 7, 2024

@anitagraser , Yes, that's right. The JSON from https://feed.qgis.org/?lang=en&json=1 is fetched every 12 hours and then displayed on the website when we build.

@EmHain8
Copy link
Contributor

EmHain8 commented Oct 8, 2024

  1. I know the Text comes directly from the old site, but I think it can be updated to be more effective. The 'There' confuses me. Perhaps change it to "Click here to access plugins ready to be used."
  2. Add in some information about the category of plugins or is this accessed somewhere else e.g. Stable, Experimental, QGIS server plugin, Depreciated.
  3. I don't know if this is the right place, but I wonder if we could write something about if a plugin is depreciated and you want to revive it, how you go about doing that?

Otherwise I love the new Plugin Portal! Great work and thank-you.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 8, 2024

Thanks for the review @EmHain8, they are well noted. I will improve the plugin's website accordingly.

I don't know if this is the right place, but I wonder if we could write something about if a plugin is depreciated and you want to revive it, how you go about doing that?

For now, we only have the documentation about publishing a plugin on the Plugin website (https://staging.plugins.qgis.org/publish/). But I think it's a great idea and it would be useful to add that to the website along with other documentation about plugin management. I'm thinking about adding a "Documentation > Manage a plugin" menu and including the documentation about reviving a deprecated as a submenu for example.

image

Please feel free to add a comment on the PR at https://github.com/Xpirix/QGIS-Plugins-Website/pull/5 if you have any questions or other suggestions.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 8, 2024

I have also created a new issue for the Documentation part at https://github.com/Xpirix/QGIS-Plugins-Website/issues/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants