metric: connected peer count #41
Open
+48
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
| "lean_process_start_time_seconds", | ||
| "UNIX timestamp of the moment the process started") | ||
|
|
||
| METRIC_GAUGE(connected_peer_count, "TODO_NAME_connected_peer_count", "TODO_HELP") |
Collaborator
There was a problem hiding this comment.
My suggestion is to move these metrics to a separate network_metrics.def in the networking module. The number of the network metrics will grow further.
Collaborator
|
Peer connection metrics are listed here feat: add network peer connection metrics #13. The initial implementation can be without labels depending on the complexity of adding them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because dead QUIC connection may remain alive for some time,
may need to reduce alive timeout in QUIC config