Skip to content

Conversation

Copy link

Copilot AI commented Dec 24, 2025

The public ping() method automatically updates the RTT repository on successful pings (added in commit 1dc4258), but this side effect was not documented in the API comments.

Changes

  • Added documentation clarifying that ping() updates the RTT repository with measured round-trip time
  • Updated .gitignore to exclude build artifacts (.venv, .vcpkg, .build)
/**
 * Performs a single ping on the given connection.
 * Opens a new stream for the ping.
 * On successful ping, automatically updates the RTT repository with the
 * measured round-trip time.
 * @param conn Connection to ping.
 * @param timeout Timeout for the ping operation.
 * @return RTT of the ping.
 */
CoroOutcome<std::chrono::microseconds> ping(
    std::shared_ptr<connection::CapableConnection> conn,
    std::chrono::milliseconds timeout);

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Address feedback on the SOON pull request docs: document updateRtt side effect in ping method Dec 24, 2025
Copilot AI requested a review from kamilsa December 24, 2025 07:38
@kamilsa kamilsa closed this Dec 24, 2025
@kamilsa kamilsa deleted the copilot/sub-pr-18 branch December 24, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants