Skip to content

Conversation

@turuslan
Copy link
Contributor

  • open ipv6 udp socket lazily (shadow doesn't support ipv6)

@turuslan turuslan requested a review from kamilsa October 14, 2025 12:03
@kamilsa kamilsa requested a review from Copilot October 14, 2025 12:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the QUIC transport to support environments that don't have IPv6 support (specifically Shadow simulator) by lazily opening UDP sockets instead of creating them upfront during construction.

  • Changed socket initialization from eager (constructor) to lazy (on-demand during dial)
  • Updated makeClient method to return a result type and handle socket opening errors
  • Modified client initialization to check for null clients and create them as needed

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/transport/quic/transport.cpp Implements lazy socket creation with error handling and removes eager IPv4/IPv6 client initialization
include/libp2p/transport/quic/transport.hpp Updates method signature to return result type for error handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@turuslan turuslan merged commit bba324f into main Oct 14, 2025
2 checks passed
@turuslan turuslan deleted the shadow branch October 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants