Add errors helper package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emruz Hossain <[email protected]>
hossainemruz
requested review from
areina,
pedjak,
bashofmann,
superseb and
Robert-Stam
Signed-off-by: Emruz Hossain <[email protected]>
Signed-off-by: Emruz Hossain <[email protected]>
Signed-off-by: Emruz Hossain <[email protected]>
Signed-off-by: Emruz Hossain <[email protected]>
Signed-off-by: Emruz Hossain <[email protected]>
pedjak
reviewed
Mar 7, 2025
Signed-off-by: Emruz Hossain <[email protected]>
pedjak
requested changes
Mar 10, 2025
Signed-off-by: Emruz Hossain <[email protected]>
pedjak
reviewed
Mar 10, 2025
pkg/errors/errors.go
Outdated
| return w.err | ||
| } | ||
|
|
||
| type Metadata []string |
There was a problem hiding this comment.
If we use []any, this will allow following usage:
return errhelper.WithMetadata(err, errMetadata.Extend("key1", "value1"))This will call WithMetadata() function with only one key of type Metadata{"key1", "value1"} which is not what we want.
Using []string enforce that you have expanded the returned slice and use following instead:
return errhelper.WithMetadata(err, errMetadata.Extend("key1", "value1")...)Signed-off-by: Emruz Hossain <[email protected]>
pedjak
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper package for wrapping errors with additional context.