-
Notifications
You must be signed in to change notification settings - Fork 1
Implement missing eperimental variable functionality #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
KochTobi
merged 101 commits into
development
from
feature-1178/1178-implement-missing-eperimental-variable-functions
Oct 9, 2025
Merged
Changes from all commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
6ff8af9
Preserve order of levels
KochTobi f7b340d
make it compile again
KochTobi 9b0e84c
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi bdca38b
wip
KochTobi bda4861
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi 3103d69
wip
KochTobi 0d0cb6f
section off regions and add borders
KochTobi faec88b
Replace ontology-term CSS class
KochTobi 4fa7603
Remove CSS classes
KochTobi 9ff8c33
wip
KochTobi 5926d06
add missing variables
KochTobi e542fb0
replace lumo with custom variables
KochTobi e78f5d1
move ButtonFactory
KochTobi 3d56282
add icon button factory method
KochTobi 5c95256
update demo
KochTobi 643e8a7
Fix label css
KochTobi 1b5e9f8
replace with classes
KochTobi f9ea42c
introduce delete event
KochTobi d58801c
wip
KochTobi f1746f5
add restoration option for deleted variables
KochTobi 41a1630
Add Nullable annotation to DialogBody.java#with method
KochTobi 621a146
remove test button
KochTobi 0ce5a9c
Fix value handling of level field
KochTobi eecadeb
Add paste behaviour
KochTobi cea127e
address code smells
KochTobi 0f5fa65
hide public constructor
KochTobi cf8b3d5
simplify memento interface
KochTobi 73a0224
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi e3cc6c7
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi 2cf58c9
Handle validation
KochTobi 72261de
Make InputValidation combinable
KochTobi 67031e3
require all snapshots to be serializable
KochTobi 099ce4f
adapt validation to validate multivariable constraints
KochTobi f0602d4
wip
KochTobi 4bed019
Add DragDropList.java
KochTobi 7857d7f
Push UI code
KochTobi 6cefc83
extract classes and add add dialog
KochTobi c1ec84c
Load values and call the service
KochTobi 10e708f
remove unused method
KochTobi fde84e6
Add empty input if no variables exist
KochTobi 8d5aff9
Add variable deletion confirm dialog
KochTobi cc9dd3e
add bold css class
KochTobi 3dd52b8
add tooltip to locked levels
KochTobi 14b65e8
extract change records
KochTobi 7804482
add scroll css classes
KochTobi f9ef3e1
make drag-drop configurable
KochTobi bb6e4c3
replace lumo var with own variable definition
KochTobi c649bba
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi 72c3290
remove duplicate css classes
KochTobi 17de7d3
use correct css class
KochTobi a4d131a
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi 9402809
Fix import
KochTobi 2da3926
propagate level changes
KochTobi 0baad2f
Cleanup methods
KochTobi 3b0ef2f
Fix inverted boolean
KochTobi 51a7e6b
respect enabled state when adding and removing items
KochTobi 4b065eb
use correct variable name in changes
KochTobi 3ace81e
Prevent unintended modification on card collection
KochTobi d434724
reload experimental variables upon completion
KochTobi d877a75
address code smells
KochTobi ef71332
enhance dragdrop
KochTobi e935fce
reload information on attach event
KochTobi bd811f5
remove unused code
KochTobi 02f66da
return experimental variables sorted by variable name
KochTobi 1672d30
Correct icon colors
KochTobi 70cbc59
update indexes
KochTobi fc66f8a
change dialog size back to medium
KochTobi 8ebf805
remove unused css
KochTobi 2a3e038
fix border colors
KochTobi 87c5e4c
Trim variable name input
KochTobi 9529ca0
Fix padding for linked orcid account
KochTobi 912c08b
Change message for duplicate variable names
KochTobi 13abd2a
address wrong padding
KochTobi ac82503
Remove specific border color for choice box
KochTobi c6ae679
Clarify error colors
KochTobi bdfd01b
Add dialog with dangerous confirm action
KochTobi 9d7d112
Ask directly instead of restore option
KochTobi bc00aa4
Improve check for defined variables
KochTobi 15efb17
Do not silently remove dupliate levels in experimental variable
KochTobi aba4aa2
address review
KochTobi d707acf
address review
KochTobi bbe23b3
Fix sorting of variables
KochTobi a58da23
Remove duplicate error when level value changes
KochTobi 4333831
Remove error message for duplicate variable name
KochTobi 55aab8e
Merge branch 'development' into feature-1178/1178-implement-missing-e…
KochTobi 2fb4110
replace choice-box css
KochTobi 069746c
Change error text
KochTobi 915aa18
update dev.bundle
KochTobi cafb294
Fix css color
KochTobi 2ef7467
Change delete confirm text
KochTobi b87ee8c
Link javadoc
KochTobi 48e46db
Add clarifying javadoc
KochTobi 6e014ed
remove all the generics from javadoc
KochTobi 18944e9
address review
KochTobi 82786fb
add missed change
KochTobi 885521d
address exception
KochTobi da74ce4
Use deep copy instead of inplace modification
KochTobi d779b62
Remove comment
KochTobi 2f4b39a
Provide exception supplier
sven1103 37a5bec
Use UIHandle
KochTobi 5b7f063
Merge remote-tracking branch 'origin/feature-1178/1178-implement-miss…
KochTobi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
application-commons/src/main/java/life/qbic/application/commons/CanSnapshot.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| package life.qbic.application.commons; | ||
|
|
||
| /** | ||
| * Interface to implement the Memento/Snapshot pattern. <a | ||
| * href="https://refactoring.guru/design-patterns/memento">Memento Pattern</a> Originators of | ||
| * Mementos or Creators of Snapshots should implement this interface. | ||
| */ | ||
| public interface CanSnapshot { | ||
|
|
||
| /** | ||
| * Capture the internal state and expose it as a Snapshot. | ||
| * | ||
| * @return the created snapshot | ||
| */ | ||
| Snapshot snapshot(); | ||
|
|
||
| /** | ||
| * Adapts the internal state to match the information provided by the snapshot. The method can | ||
| * fail throwing a {@link SnapshotRestorationException} for unknown types of Snapshots. | ||
| * <p> | ||
| * It is the responsibility of the implementation to make sure after successful application or | ||
| * failure, the internal state of the object is valid. | ||
| * <p> | ||
| * After snapshot restoration failure. The object is expected to revert all modifications made by | ||
| * the attempt. | ||
| * | ||
| * @param snapshot the snapshot to be restored | ||
| * @throws SnapshotRestorationException thrown when snapshot restoration failed. | ||
| */ | ||
| void restore(Snapshot snapshot) throws SnapshotRestorationException; | ||
|
|
||
| /** | ||
| * Indicates that a snapshot cannot be used to restore the state of the originator. | ||
| */ | ||
| class SnapshotRestorationException extends RuntimeException { | ||
|
|
||
| public SnapshotRestorationException(String message) { | ||
| super(message); | ||
| } | ||
|
|
||
| public SnapshotRestorationException(String message, Throwable cause) { | ||
| super(message, cause); | ||
| } | ||
| } | ||
| } |
11 changes: 11 additions & 0 deletions
11
application-commons/src/main/java/life/qbic/application/commons/Snapshot.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package life.qbic.application.commons; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
||
| /** | ||
| * Interface for the Memento in the <a | ||
| * href="https://refactoring.guru/design-patterns/memento">Memento Pattern</a> | ||
| */ | ||
| public interface Snapshot extends Serializable { | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.